Black Highlighter — May 25th, 2019
This session picked up where we left off at the last weekend session, finishing the “other apps” list in the help section. When I last worked on it, I’d loaded the list of apps from the App Store lookup API and displayed the app name. However, trying to show the app icon led to a broken design; the app icon covered up the beginning of the app name! This was fixed by creating a new cell subclass that displayed an icon and a label, laying them out appropriately.
The next ticket on the chopping block was about fixing the layout of the photo picker. While I’d picked some item sizes that looked good on the few devices I was testing with, different devices and presentations (such as iPad split view) didn’t look so great. Instead of sticking to a finite number of item sizes, I played with the iOS Photos app to determine a formula for figuring out an item size that looked good in most cases. Rather than trying to make sure that this worked out right on a bunch of different simulators, I wrote unit tests that prepared the layout and then make sure they fit the expected the results of the formula.
Next up, prompting the user for app reviews. I don’t really love doing this, but Apple’s new native dialog isn’t so bad, and app reviews really do help. I tried to make it as unobtrusive as possible, showing the dialog directly after saving. I don’t even try to ask for a review after the first save; the app will prompt for a review after the third, tenth, and thirtieth saves. However, this current method will stop trying to show reviews forever after those 30 saves. I filed a ticket to fix this in the future, but it’s probably not important to get finished for version 2.0.
Finally, I wrapped up by implementing support for dragging and dropping images into the photo picker to open an image that isn’t necessarily in your photo library. This turned out to be way easier in theory than in practice, as the photo editor expected everything to be a PHAsset rather than a UIImage. I added a UIImage parameter to the photo editor, and this seems to work now. I suspect this area will need a refactor in the future.
Commits Made
- Add Carthage step to GitLab CI
- Display app icons for other app entries
- Fix layout of photo album cells in photo picker
- Display app ratings prompt on save
- Add drop support for photo picker
Tickets Closed
Tickets Created
Project Stats
- Sessions Completed
- 22
- Days Since Start
- 55
- Issues Closed
- 34
- Issues Open
- 6
- Percent Complete
- 85.0%
Replay
Coming soon.